On Sun, Nov 18, 2018 at 11:17:37PM -0300, Alvaro Herrera wrote: > To be certain I'm not going against some old decision, I digged up > Amit's old patches. Turns out he submitted psql's describe.c using the > term "partitioned table" on August 10th [1] and then based on a > discussion where Robert suggested calling these new objects "partition > roots" instead to avoid confusion, it was changed to "table" in the next > submission on August 26th [2]. It seems the right call to have used the > term "table" in many places (rather than "partition roots"), but at > least in psql's \dt it seems extremely useful to show the type as > "partitioned table" instead, because it is one place where the > distinction is clearly useful.
+1. > In this thread there have been no contrary votes, so I'm pushing this > part soon. > > [1] https://postgr.es/m/ad16e2f5-fc7c-cc2d-333a-88d4aa446...@lab.ntt.co.jp > [2] https://postgr.es/m/169708f6-6e5a-18d1-707b-1b323e4a6...@lab.ntt.co.jp Sorry for degressing, but could you also update \di at the same time so as it shows "partitioned index"? listTables() should be switched to use partitioned tables and partitioned indexes, and permissionsList() has a reference to partitioned tables. While on it, this gives the attached.. -- Michael
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 4ca0db1d0c..8e06097442 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -955,7 +955,7 @@ permissionsList(const char *pattern)
gettext_noop("materialized view"),
gettext_noop("sequence"),
gettext_noop("foreign table"),
- gettext_noop("table"), /* partitioned table */
+ gettext_noop("partitioned table"),
gettext_noop("Type"));
printACLColumn(&buf, "c.relacl");
@@ -3524,8 +3524,8 @@ listTables(const char *tabtypes, const char *pattern, bool verbose, bool showSys
gettext_noop("sequence"),
gettext_noop("special"),
gettext_noop("foreign table"),
- gettext_noop("table"), /* partitioned table */
- gettext_noop("index"), /* partitioned index */
+ gettext_noop("partitioned table"),
+ gettext_noop("partitioned index"),
gettext_noop("Type"),
gettext_noop("Owner"));
signature.asc
Description: PGP signature
