On 2018-Nov-06, Emre Hasegeli wrote: > > Surely the comment in line 3839 deserves an update :-) > > Done. > > > This seems good material. I would put the detailed conventions comment > > separately from the head of the file, like this (where I also changed > > "Type1 *type1" into "Type1 *obj1", and a few "has" to "have") > > Looks better to me. I found one more "has" and changed it.
Pushed, with some further minor changes. I decided not to remove the redundant comments that your patch was removing, as I felt that it's better to keep the API contract together with the function definition. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
