On Mon, Sep 24, 2018 at 9:28 AM Elvis Pranskevichus <elpr...@gmail.com> wrote:
> On Thursday, March 1, 2018 4:25:16 AM EDT Andres Freund wrote: > > A CF entry for this patch has been created yesterday, without any > > changes having happend since the above status update. Given that > > there's been no progress for multiple commitfests, and this is the > > last CF, this doesn't seem appropriate. Therefore marked as returned > > with feedback. > > Sorry for the long silence on this. I'm attaching a rebased and > cleaned-up patch with the earlier review issues addressed. I've checked > all relevant tests and verified manually. > > Elvis After taking a look at the updated patch, it appears to address the review feedback which I provided. However, the patch didn't apply cleanly for me, so it likely needs a quick look along with a rebase. After looking at the patch [1] to add a "prefer-read" option to target-session-attrs which is also up for consideration this commitfest, I was wondering, assuming it is desirable to have both "prefer-read" and "read-only" modes, does it make sense for the "prefer-read" option to also be implemented with a ParameterStatus message instead of using polling? [1] https://commitfest.postgresql.org/20/1677/
