On 2018-Nov-08, Tomas Vondra wrote: > I'm not sure splitting the headers like this is needed, actually. It's true > we're replacing pgstat.c with something else, but it's still related to > stats, backing pg_stat_* system views etc. So I'd keep as much of the > definitions in pgstat.h, so that it's enough to include that one header > file. That would "unbreak" the extensions.
pgstat.h includes a lot of other stuff that presumably isn't needed if all some .c wants is in bestatus.h, so my vote would be to make this change *if it's actually possible to do it*: you want the affected headers to compile standalone (use cpluspluscheck or similar to verify this), for one thing. > Renaming pgstat_report_* functions to bestatus_report_* seems unnecessary to > me too. The original names seem quite fine to me. Yeah, this probably keeps churn to a minimum. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
