> On Nov 19, 2026, at 15:19, Fujii Masao <[email protected]> wrote:
> 
> On Thu, Nov 12, 2026 at 9:36 AM Chao Li <[email protected]> wrote:
>> This call is intended to delete a temporary file, so I don’t think an LZ4F 
>> error should prevent that deletion. Maybe fix this leak as well?
> 
> Maybe yes, seems we can attempt to unlink the file on error when
> CLOSE_UNLINK is specified. This should also cover close() and gzclose()
> failures, not just LZ4 finalization or final write failures? If so, I think
> a separate patch would be better, since this changes cleanup behavior
> beyond the LZ4 resource leak fix.
> 

Sounds fair.

Would you prepare for a follow up patch? Or if you want me to do so?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Reply via email to