> Same as the other your patch, the fix looks good, however, there is an > earlier patch [1] already. > > [1] > https://postgr.es/m/caf1dzpxjeghhpgkzewmpuoxdzwwern79yrodokwryat7bdn...@mail.gmail.com
Hi, As pointed out, the same issues have already been addressed in an earlier patch, so I am withdrawing my patches. Regards, Taiki Koshino<[email protected]> SRA OSS K.K. TEL: 03-5979-2701 FAX: 03-5979-2702 URL: https://www.sraoss.co.jp/ ________________________________ 差出人: Chao Li <[email protected]> 送信日時: 2026年11月4日 16:08 宛先: Koshino Taiki <[email protected]> CC: PostgreSQL Hackers <[email protected]>; Yugo Nagata <[email protected]> 件名: Re: [PATCH v1] psql: Do not complete JSON format for COPY FROM > On Nov 4, 2026, at 09:22, Koshino Taiki <[email protected]> wrote: > > Hi, > > I noticed that psql's tab completion suggests the JSON format for both > directions of COPY. > > For example: > > COPY t1 FROM STDIN WITH (FORMAT <TAB><TAB> > binary csv json text > > However, the documentation says that the JSON format is allowed only > for COPY TO. If a user selects the suggested "json" candidate, the > command fails: > > COPY t1 FROM STDIN WITH (FORMAT JSON); > ERROR: COPY FORMAT JSON is not supported for COPY FROM > > I think it is misleading for tab completion to suggest syntax that is > explicitly unsupported by the documentation and rejected by the > server. > > The attached patch checks the COPY direction and offers "json" only > for COPY TO. This applies to both COPY and \copy completion. > > There is already a separate discussion proposing support for COPY FROM > with FORMAT json [1]. If that support is committed, the completion can > of course be extended at the same time. However, in the current tree > COPY FROM does not support JSON, so I think tab completion should > reflect the currently implemented and documented behavior. > > [1] > https://www.postgresql.org/message-id/CAEG8a3%2BwxMXGLcnrDzSF0qTDzH%2BK7_x0FWNAcu-H_j8gKiwFVw%40mail.gmail.com > > Regards, > > > Taiki Koshino<[email protected]> > SRA OSS K.K. > TEL: 03-5979-2701 FAX: 03-5979-2702 > URL: https://www.sraoss.co.jp/ > > <v1-0001-psql-Do-not-complete-JSON-format-for-COPY-FROM.patch> Same as the other your patch, the fix looks good, however, there is an earlier patch [1] already. [1] https://postgr.es/m/caf1dzpxjeghhpgkzewmpuoxdzwwern79yrodokwryat7bdn...@mail.gmail.com Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
