On Thu, 5 Nov 2026 at 16:09, Ajin Cherian <[email protected]> wrote: > > On Thu, Nov 5, 2026 at 10:47 AM Peter Smith <[email protected]> wrote: > > > > On Wed, Nov 4, 2026 at 9:06 PM Ajin Cherian <[email protected]> wrote: > > ... > > > To make the tests pass, I've included the v1 patch from [1], unchanged, > > > as 0001. > > > > > > 0002 adds tests to 011_generated.pl for a table whose only column is > > > VIRTUAL, and one whose only column is STORED with > > > publish_generated_columns = none, in both text and binary mode. > > > > > > [1] > > > https://www.postgresql.org/message-id/CAL5_ZS1bnYkK_GrA4N4SVKYgYsMMJxL9416m%3DvECAjrcwmQkkg%40mail.gmail.com > > > > > > > Hi Ajin. > > > > Thanks for the 0002 patch! > > > > Basically, it LGTM, but here are a couple of very minor review comments. > > > > Hi Peter, > > Thanks for your comments. Addressed. Also attached the new patch > posted in [1] as patch 0001. > > [1] > https://www.postgresql.org/message-id/CAL5_ZS1bnYkK_GrA4N4SVKYgYsMMJxL9416m%3DvECAjrcwmQkkg%40mail.gmail.com > Hi Ajin,
I have reviewed and tested the v2-0002 patch. It looks good to me. Thanks, Shlok Kyal
