> On Nov 3, 2026, at 10:26, Etsuro Fujita <[email protected]> wrote:
>
> Hi,
>
> While working on the Asynchronous-MergeAppend patch, I noticed
> $SUBJECT: "Wait or poll for async events." for the call to
> ExecAppendAsyncEventWait. We call it with node->as_syncdone=true,
> which makes it wait until at least one event occurs, as commented
> above, so it never polls. Attached is a small patch for fixing that
> comment.
>
> Best regards,
> Etsuro Fujita
> <fix-comments.patch>
The fix looks good to me.
Should we also update the header comment of ExecAppendAsyncEventWait since it
only says “wait or poll” without explaining when to wait and when to poll?
Something like:
```
/*
* ExecAppendAsyncEventWait
*
* Wait or poll for file descriptor events and fire callbacks.
* If as_syncdone is true, wait until at least one event occurs;
* otherwise, poll without waiting so synchronous execution can
proceed.
*/
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
