Hi David,

v3 looks good to me.

One thing I put under 0002 last time is really about 0001. With
ST_COMPARE_RUNTIME_POINTER and a pointer element type, the typedef
gives const Item ** but the sort passes Item **, so clang does not like it.


Writing ST_ELEMENT_TYPE const * in the typedef fixes it.

Thanks,
Shihao

Attachment: st_ptr_runtime-rerun.out
Description: Binary data

Reply via email to