fujii-san,
Thank you for the suggestion.
Isn't it better to add "shared" to the error message to clarify
which buffers are involved, as the local-buffer message does?
I agree that explicitly mentioning shared buffers makes the error clearer.
I prefer the latter because "could not" describes the failed attempt
more clearly. If we adopt this, for consistency, it might be better
to also change the local-buffer message.
Agreed. I changed the messages in v2 to:

could not find an unpinned shared buffer
could not find an unpinned local buffer

I also updated the regression test expected output accordingly.

Best regards,
Xueting Ma

Attachment: v2-0001-Report-unpinned-buffer-errors-as-insufficient-res.patch
Description: v2-0001-Report-unpinned-buffer-errors-as-insufficient-res.patch

Reply via email to