Hi >On 2026/10/14 20:36, Fujii Masao wrote: > On Wed, Oct 14, 2026 at 5:33 PM Takeshi Ideriha > <[email protected]> wrote: >> But I'd like to focus on correcting the wrong sentence for now. > > +1 > > So, IMO, it's better to omit the OOM score description because it's not > needed to correct the existing text and is already explained later in > the same section.
On second thought, I agree with you. I'd like to keep the postgres doc concise as possible. Fixed in v3 patch. > + If a child process is terminated, all connections > + will be terminated and <productname>PostgreSQL</productname> will > + automatically restart when > + <link > linkend="guc-restart-after-crash"><varname>restart_after_crash</varname></link> > + is on. If it is off, <productname>PostgreSQL</productname> will stop and > + must be restarted manually. > > This description seems misleading because not all child process > terminations have this effect. For example, terminating the syslogger > does not terminate existing connections. But, to address this, > listing all the exceptions here would be overkill, though. So, how about > using "typically" instead, as follows? > > --------------- > If a child process is terminated, PostgreSQL will typically terminate > all remaining connections and either recover automatically, if > restart_after_crash is enabled, or shut down. If PostgreSQL shuts > down, it will need to be restarted to recover. > --------------- Oh, syslogger. It's true. Thank you for pointing this out and great suggestion. Your suggestion looks much more correct and simple. I use your wordings in v3 patch as is. Regards, Takeshi Ideriha
From 2367c60c0a40bba5e1d9b8cd714dabce8ed93f13 Mon Sep 17 00:00:00 2001 From: Takeshi Ideriha <[email protected]> Date: Thu, 8 Oct 2026 10:40:20 +0900 Subject: [PATCH v3] Fix explain how postgres behaves when an OOM killer is invoked. --- doc/src/sgml/runtime.sgml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml index d9984910cc4..7db6bc7d1a5 100644 --- a/doc/src/sgml/runtime.sgml +++ b/doc/src/sgml/runtime.sgml @@ -1359,9 +1359,15 @@ Out of Memory: Killed process 12345 (postgres). </programlisting> This indicates that the <filename>postgres</filename> process has been terminated due to memory pressure. - Although existing database connections will continue to function - normally, no new connections will be accepted. To recover, - <productname>PostgreSQL</productname> will need to be restarted. + If the postmaster is terminated, all connections will eventually be + terminated. To recover, <productname>PostgreSQL</productname> will + need to be restarted. + If a child process is terminated, <productname>PostgreSQL</productname> will + typically terminate all remaining connections and either recover + automatically, if + <link linkend="guc-restart-after-crash"><varname>restart_after_crash</varname></link> + is enabled, or shut down. If <productname>PostgreSQL</productname> shuts + down, it will need to be restarted to recover. </para> <para> -- 2.50.1 (Apple Git-155)
