Hi, On Fri, Sep 11, 2026 at 5:52 PM Amit Langote <[email protected]> wrote: > On Thu, Sep 10, 2026 at 5:58 PM Amit Langote <[email protected]> wrote: > > On Thu, Sep 10, 2026 at 3:20 PM Amit Langote <[email protected]> > > wrote: > > > I have now reverted batching in REL_19_STABLE after pushing the > > > snapshot fix for the per-row path to master and REL_19_STABLE. and . > > > Batching remains in master for now.
When 25649d6e79 removed batching from REL_19_STABLE, I was not careful enough to remove some setup steps in the test added by 1390182683 (the snapshot fix, committed before the revert) to ensure that the per-row path, whose bug it fixed, was indeed taken. Attached patch removes that obsolete and unnecessary part of the test case. I checked that the test case still verifies that the PushActiveSnapshot() added as a fix is necessary. Note that this is for REL_19_STABLE only, because master still has batching, though I'm starting to have second thoughts about that. More on that later. -- Thanks, Amit Langote
0001-Simplify-RI-fast-path-active-snapshot-regression-tes.patch
Description: Binary data
