On Tue, Sep 22, 2026 at 2:31 AM Zsolt Parragi <[email protected]> wrote:
>
> Hello!
>
> An automated claude review found a residual crash in pgoutput after
> the committed fix, which repeatedly crashes the walsender following an
> interrupted ALTER TABLE ... DETACH PARTITION ... CONCURRENTLY.
>
> 0001 contains a test case and a simple fix.

Thanks for the patches. 001 is a known issue as Nisha pointed out.

> And after further looking, I realized that there's one more leftover
> issue, which doesn't cause a crash but failures in subscribers:
> pg_get_publication_tables only relied on relispartition instead of
> following the same approach as the previous fix commit and 0001. 0002
> modifies it to match the other locations.

I earlier pointed the issue in pg_get_publication_tables's
is_table_publishable_in_publication() in [1] (see pt b), which your
002 has addressed.  I agree with the problem and the fix for the HEAD.
I can reveiw in detail once we plan to address all such issues on
HEAD.

[1]:https://www.postgresql.org/message-id/CAJpy0uB-EpnNPUEFzLT38JX84swWFnsRbhPKCpnzSbnb1UNSmQ%40mail.gmail.com

thanks
Shveta


Reply via email to