On Fri, Oct 19, 2018 at 01:05:52PM +0900, Amit Langote wrote: > As I said above, the price of removing relhassubclass might be a bit > steep. So, the other alternative I mentioned before is to set > relhassubclass correctly even for indexes if only for pg_partition_tree to > be able to use find_inheritance_children unchanged.
Playing devil's advocate a bit more... Another alternative here would be to remove the fast path using relhassubclass from find_inheritance_children and instead have its callers check for it :) Anyway, it seems that you are right here. Just setting relhassubclass for partitioned indexes feels more natural with what's on HEAD now. Even if I'd like to see all those hypothetical columns in pg_class go away, that cannot happen without a close lookup at the performance impact. -- Michael
signature.asc
Description: PGP signature
