On 2018-10-18 22:17:55 +0200, Peter Eisentraut wrote: > I'd perhaps change the signature > > #define unconstify(underlying_type, var) > > because the "var" doesn't actually have to be a variable.
Hm, so expr, or what would you use? > Attached is my previous patch adapted to your macro. > > I'm tempted to get rid of the stuff in dfmgr.c and just let the "older > platforms" get the warning. Yea, that works for me. Are you planning to apply this? Greetings, Andres Freund