Hi, On Fri, Sep 4, 2026 at 11:02 AM Masahiko Sawada <[email protected]> wrote: > > I reviewed the patch. It's simple and I agree to add a check for user > catalog tables. I've slightly rephrased the comment in > check_concurrent_repack_requirements() to clarify the reason why > REPACK (CONCURRENTLY) doesn't support user catalog tables while it > does for normal tables even though it's a MVCC-unsafe operation. Also > updated the commit message as well. Please review it.
Thanks for reviewing it. The v4 patch looks good to me. pgindent and make check are happy. A nit: Code comment: + * tables under a historic snapshot. Removing this check requires making + * it MVCC-safe and logical rewrite mappings. + */ Commit message: Disallow REPACK (CONCURRENTLY) on user catalog tables. Removing this check requires making it MVCC-safe and logical rewrite mappings. "Making it logical rewrite mappings" doesn't read correctly. How about "Removing this check requires making it MVCC-safe and adding logical rewrite mapping support" or such? -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
