Hi, On Sun, Aug 30, 2026 at 9:40 PM Amit Kapila <[email protected]> wrote: > > > Hi Amit, By restricting in the code, does that mean adding an Assert, > > or a WARNING, or a WARNING plus slot release (not an error), in the > > replication slot subxact callback on the commit path, instead of > > handing the slot off to the parent across the subtransaction boundary? > > Yes, I would prefer WARNING similar to existing cases for resource > leaks in commit paths. One example of a similar existing case is: > ------ > /* Complain if any allocated files remain open at commit. */ > if (isCommit && numAllocatedDescs > 0) > elog(WARNING, "%d temporary files and directories not closed at > end-of-transaction", > numAllocatedDescs); > ------- > > Based on above, I am imagining a check/WARNING on lines of:
Thanks, Amit. That works for me. Please find the attached v15 patch. If it looks good, I can prepare patches for the back branches. -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
v15-0001-Fix-replication-slot-leak-on-error-caught-in-a-s.patch
Description: Binary data
