Hello! > RelationFindReplTupleByIndex() is an extern function declared in a > core executor header (executor.h). Adding a new parameter > (isIdxSafeToSkipDuplicates) changes its calling convention. > Similarly I'm not sure of adding isidentity to LogicalRepRelMapEntry > in back branches as it will change its size and memory layout.
Yep, fair, thanks.
In v2 I put a new flag into padding and used the same pattern for the
function as in 9e47718250d.
abidiff now shows that:
'struct LogicalRepRelMapEntry' changed:
type size hasn't changed
1 data member insertion:
'bool isidentity', at offset 89 (in bytes)
I think it is ok for such a type. I couldn't find any usage in extensions.
Should we update .abi-compliance-history in such a case?
Best regards,
Mikhail.
nocfbot-v2-REL_17_STABLE.patch
Description: Binary data
nocfbot-v2-REL_16_STABLE.patch
Description: Binary data
nocfbot-v2-REL_18_STABLE.patch
Description: Binary data
v2-master.patch
Description: Binary data
