> I think v3 is preferable. The corresponding relational query in
> ddl.sgml is also long, but it isn't a GRAPH_TABLE example, so I think
> we should keep this patch focused on reformatting GRAPH_TABLE examples.

Thanks, I agree v3's scope is the right one to go with,
so I'll keep this patch focused on the GRAPH_TABLE examples and
leave the JOIN query and other cases out of scope here.

> Regarding v3 patch, this example in queries.sgml seems to be missing
> the closing parenthesis for GRAPH_TABLE. That is, I think ")" should be
> added at the end of the example above.

I've added the missing closing parenthesis and attached a v5 patch.

Regards,
Taiki Koshino

Taiki Koshino<[email protected]>
SRA OSS K.K.
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/


________________________________


On Wed, Aug 26, 2026 at 10:25 AM Koshino Taiki <[email protected]> wrote:
> I wasn't sure whether this should be part of the same patch,
> so I've attached two versions: v3 leaves it untouched,
> and v4 includes the change. Let me know which you'd prefer.

I think v3 is preferable. The corresponding relational query in
ddl.sgml is also long, but it isn't a GRAPH_TABLE example, so I think
we should keep this patch focused on reformatting GRAPH_TABLE examples.

If necessary, you could start a separate thread about reformatting long
query examples in the documentation. It might be better to review all
such examples and reformat them consistently, rather than addressing
only the long query in ddl.sgml mentioned here.


-GRAPH_TABLE (mygraph MATCH (p IS person)-[h IS has]->(a IS account)
-             COLUMNS (p.name AS person_name, h.since AS
has_account_since, a.num AS account_number)
+GRAPH_TABLE (mygraph
+    MATCH (p IS person)-[h IS has]->(a IS account)
+    COLUMNS (p.name AS person_name, h.since AS has_account_since,
a.num AS account_number)

Regarding v3 patch, this example in queries.sgml seems to be missing
the closing parenthesis for GRAPH_TABLE. That is, I think ")" should be
added at the end of the example above.


BTW, it would be helpful if you could trim the quoted text in your replies,
leaving only the parts relevant to your response. There's no need to
include the entire previous email at the bottom.

Regards,

--
Fujii Masao

Attachment: v5-0001-doc-Reformat-SELECT-queries-using-GRAPH_TABLE.patch
Description: v5-0001-doc-Reformat-SELECT-queries-using-GRAPH_TABLE.patch

Reply via email to