Hi, On Thu, Aug 27, 2026 at 12:19 PM Nathan Bossart <[email protected]> wrote: > > The patch looks reasonable to me.
+1. > On Thu, Aug 27, 2026 at 03:55:11PM -0300, Matheus Alcantara wrote: > > Added this new test case on attached. > > I'm not sure the new tests are necessary. It seems unlikely that we'll > accidentally remove the flags down the road. I don't fully agree with this. These tests helped identify an issue, and removing these flags from a fairly new repack code is a behavioral change, even if it doesn't bring in additional code coverage. Maybe have these just for HEAD? -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
