Patch v2 review comments: 1. Oid puboid; bool nulls[Natts_pg_publication]; Datum values[Natts_pg_publication]; + PubOpts opts; HeapTuple tup; - bool publish_given; - PublicationActions pubactions; - bool publish_via_partition_root_given; - bool publish_via_partition_root; - bool publish_generated_columns_given; - char publish_generated_columns;
Nit. Perhaps the PubOpts should come *after* the HeapTuple, just so the nulls/values/tup all stay together like they were before. ~ Otherwise, the patch v2 LGTM On Tue, Aug 25, 2026 at 7:43 PM Miłosz Bieniek <[email protected]> wrote: > ... > > One thing I'm not so sure about is `IsSet` macro. I copied it from the > 'subscriptionscmds.c', > but maybe it should be extracted to a header file? > I would not worry about that for now. Wait to see if this patch gets any support first. ====== Kind Regards, Peter Smith Fujitsu Australia
