On Tue, Aug 25, 2026 at 5:39 PM Hayato Kuroda (Fujitsu)
<[email protected]> wrote:
>
> Thanks for updating the patch. I confirmed it could fix the issue.
>
>
> ```
> +               else
> +                       elog(ERROR, "unexpected relkind: %d", (int) relkind);
> ```
>
>
> I feel \"%c\" might be better than %d, like what ProcessUtilitySlow() does,
> because the relkind is defined as char.
>

Agreed, though %d is used for the same purpose at one place in code
but other uses %c for relkind. How about a slightly more informative
message like: elog(ERROR, "unexpected relkind \"%c\" for relation %u
in subscription %u", relkind, subrel->srrelid, subid)?

-- 
With Regards,
Amit Kapila.


Reply via email to