Hi Andrey, all, On Mon, Aug 24, 2026 at 8:32 PM Andrey Borodin <[email protected]> wrote: > > Hi ChangAo, Daniel, Enrique, > > On Mon, Jul 13, 2026 at 9:50 AM Daniel Gustafsson wrote: > > Thanks for this work, I have it on my radar to review and commit for v20, > > but will wait for the work of cleaning up and fixing the online checksums > > code which is currrently ongoing for the beta period. > > I read v2 against the current online-checksum code and the earlier design > thread. I did not find a correctness problem in the conversion. > In particular, the fixed numblocks boundary is preserved, and ending the > stream on abort releases the buffers read ahead by the stream. > > The main benefit of moving this path to ReadStream is that it can use the > future direct I/O and asynchronous I/O infrastructure without double > buffering. Enrique's results also show an immediate reduction in system > calls and execution time.
I haven't looked into the details of this patch. It seems also helpful to conduct some benchmarking for this patch on a simulated high-latency storage as suggested by Andres [1]. It helps to tell the story of performance winning more vividly. [1] https://www.postgresql.org/message-id/dmf5ladi2amq656myv7zjl4pj4u3v2cp3azteliauifxizljej@bmwabkp5hdpi -- Regards, Xuneng Zhou HighGo Software Co., Ltd.
