On Fri, 21 Aug 2026 at 17:15, Nathan Bossart <[email protected]> wrote: > > On Thu, Jan 29, 2026 at 04:17:43PM -0600, Nathan Bossart wrote: > > Here is a new version of the patch that moves the partitioning code to > > tablecmds_partition.c and creates a tablecmds_internal.h for the things in > > tablecmds.c that the partitioning code needs. The patch is still > > relatively rough. > > Here is an attempt at fixing headerscheck. >
The code needs rebase. I tried to see if I could do it myself but it seems tablecmds.c has received some modifications that at this point, I'm not sure what to remove. Some hunk worked but I guess it'll be better if you do the rebase please. At least I tried: patching file src/backend/commands/Makefile patching file src/backend/commands/meson.build Hunk #1 succeeded at 47 (offset 2 lines). patching file src/backend/commands/tablecmds.c Hunk #1 succeeded at 65 with fuzz 1 (offset 3 lines). Hunk #2 FAILED at 136. Hunk #3 succeeded at 337 (offset 10 lines). Hunk #4 succeeded at 351 with fuzz 2 (offset 10 lines). Hunk #5 succeeded at 459 (offset 45 lines). Hunk #6 succeeded at 482 (offset 46 lines). Hunk #7 succeeded at 502 (offset 46 lines). Hunk #8 succeeded at 531 (offset 46 lines). Hunk #9 succeeded at 539 (offset 46 lines). Hunk #10 succeeded at 584 (offset 46 lines). Hunk #11 succeeded at 594 (offset 46 lines). Hunk #12 FAILED at 624. Hunk #13 succeeded at 4462 (offset 102 lines). Hunk #14 succeeded at 6604 (offset 104 lines). Hunk #15 succeeded at 6785 (offset 104 lines). Hunk #16 succeeded at 6916 (offset 120 lines). Hunk #17 succeeded at 8525 (offset 125 lines). Hunk #18 succeeded at 10764 (offset 129 lines). Hunk #19 succeeded at 10942 (offset 129 lines). Hunk #20 succeeded at 11080 (offset 129 lines). Hunk #21 succeeded at 11246 (offset 129 lines). Hunk #22 succeeded at 11256 (offset 129 lines). Hunk #23 succeeded at 11319 (offset 129 lines). Hunk #24 succeeded at 12515 (offset 515 lines). Hunk #25 succeeded at 17086 (offset 712 lines). Hunk #26 succeeded at 17567 (offset 707 lines). Hunk #27 succeeded at 17585 (offset 707 lines). Hunk #28 FAILED at 18650. Hunk #29 FAILED at 21008. > -- > nathan -- Mario Gonzalez
