> On 19 Jul 2026, at 11:05, Andrey Borodin <[email protected]> wrote:
> 
> I'll follow up with the bulkwrite and checkpointer patches next.

Hi!

I looked through 0007-0009 and did not find correctness issues.

The existing COPY test uses an unlogged relation, so it does not
exercise the WAL eligibility checks in
PrepareOrRejectEagerFlushBuffer().  I tried the same test with a regular
table and it consistently combined writes.

For deterministic results I used wal_writer_delay = '10ms'.  With
synchronous_commit disabled, a fast COPY may otherwise finish before the
default 200ms WAL writer interval.  fsync can remain disabled: the test
only needs the PostgreSQL WAL flush position to advance.

Perhaps the test could run the COPY case for both unlogged and regular
tables.


Best regards, Andrey Borodin.


Reply via email to