On 11 October 2018 at 16:00, Imai, Yoshikazu <imai.yoshik...@jp.fujitsu.com> wrote: > On Thu, Sept 6, 2018 at 7:30 PM, David Rowley wrote: >> I've also included an additional test to ensure the other_subplans >> gets updated correctly. The other tests for this seem to only perform >> run-time pruning during init plan and do no further pruning, so don't >> fully test that other_subplans gets updated correctly. > > I execute the sql in this test with gdb and confirmed that it tests > other_subplans gets updated correctly. It also performs exec run-time pruning > and actually is through the codes in the patch which update other_subplans. > > I also did "check world" at the latest master e9edc1ba0b and all tests passed > successfully.
Many thanks for checking this in detail. > It seems to me that there is no problem in this patch as far. > Is there another thing I have to do for the review? There's a checklist in [1]. Perhaps there's something mentioned there that you've missed. [1] https://wiki.postgresql.org/wiki/Reviewing_a_Patch -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
