Re: [PATCH] Fix vacuum_delay_point happening inside lock

[Andrey Borodin]

> On 4 Aug 2026, at 13:13, Neil Chen <carpenter.nail...@gmail.com> wrote:
> 
>     Assert(InterruptHoldoffCount == 0);
>     Assert(CritSectionCount == 0);
> 
> With assistance from OpenAI Codex (Sol), I tried this locally; it builds and
> passes the core regression tests. I have not benchmarked the performance
> tradeoff described above.

I think that asserts are a bit too much. I observed several other
non-interruptible cases of check for interrupts. But all other cases
that I found were called sometimes without LWlocks too.

Also, make check-world is completely different beast than make check.
I will take a lot more time, but also cover a lot more cases. I used
regression tests, isolation and some subset of other tests. With Sol,
perhaps, you can scan through logs of whole make check-world.


Best regards, Andrey Borodin.