Antonin Houska <[email protected]> wrote: > 0003: > > * I'm not sure the batch-specific callbacks should be mandatory > > diff --git a/src/backend/access/table/tableamapi.c > b/src/backend/access/table/tableamapi.c > index 5450a27faeb..9ef6b5cca65 100644 > --- a/src/backend/access/table/tableamapi.c > +++ b/src/backend/access/table/tableamapi.c > @@ -45,6 +45,8 @@ GetTableAmRoutine(Oid amhandler) > Assert(routine->scan_end != NULL); > Assert(routine->scan_rescan != NULL); > Assert(routine->scan_getnextslot != NULL); > + Assert(routine->scan_getnextbatch != NULL); > + Assert(routine->batch_slot_callbacks != NULL);
I mean the callback is mandatory in the current version, but ISTM that nodeSeqscan.c does not work here if the AM does not support batching. -- Antonin Houska Web: https://www.cybertec-postgresql.com
