> On 13 Jul 2026, at 17:00, Karina Litskevich <[email protected]> > wrote:
> Simply changing num_entries to int64 leads to the change of the file > header format. I suggest changing num_entries to int64 in PG19 and > later, because it wasn't released yet, and pgss files generated by > another major version are considered to be incompatible anyway. See > the v1 patch attached. Agreed, I think we should make sure to do this once beta2 has shipped for the next beta release. > Doing the same in already released versions would require increasing > PGSS_FILE_HEADER version. I don't think it's worth it, so for older > versions I suggest just adding a comment, a check, and an explicit > conversion to int32. See the second patch attached. Given the likelihood of an issue in backbranches, we could also only apply for v19 and leave the backbranches. > Another minor problem I noticed was the definition of pgver. It's > defined as int32, but used as uint32. So I fixed it in both patches. Makes sense. -- Daniel Gustafsson
