Hi Henson, Jian,
v50-0007-tidy-plumbing-more.patch
Looks good to me.
Minor points:
In nfa_advance_alt():
while (altIdx >= 0)
{
RPRPatternElement *altElem;
RPRNFAState *newState;
/* Branch jump/next links are always -1 or a valid index */
Assert(altIdx < pattern->numElements);
Since inside the while loop altIndx == -1 case is already excluded by
the while condition, the comment for the Assert is a little bit
strange. Probably following is better?
/* Branch jump/next links are always valid index */
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
