On Wed, Jul 8, 2026 at 11:51 AM Hayato Kuroda (Fujitsu) <[email protected]> wrote: > > Dear Shveta, > > > For this reason, my inclination is to revert to the previous > > implementation, where we compare old_cluster.nsubs with > > max_active_replication_origins. But I'd like to hear what others think > > before we make this change. > > But if origin created by users (or any extensions) have already been tracking > the > Remote_lsn, they should be taken into account. If there are three enabled > subscriptions, two active user-created origins but the max_active_origin is > set > to three on the new node, the upgrading should fail. > > I prefer to preserve the current behavior of the patch, which compares > max_active_origin and total number of origins. It might cause the > false-positive, > but even now it can happen. E.g., if there was a subscription which has never > been enabled. >
Okay, I missed this point earlier. I agree, let's retain the current behaviour itself. thanks Shveta
