Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

[Fujii Masao]

On Tue, Jul 7, 2026 at 3:59 PM Michael Paquier <mich...@paquier.xyz> wrote:
>
> On Tue, Jul 07, 2026 at 12:01:59PM +0900, JoongHyuk Shin wrote:
> > Attached v8 with the errhint removed.  No other changes from v7.

We can remove assign_recovery_target_name()? With the v8 patch, it only
assigns the GUC string pointer to recoveryTargetName. It seems we could
instead have recovery_target_name store its value directly in
recoveryTargetName, remove recovery_target_name_string, and drop
the assign hook altogether. Thoughts?


> Please note that Fujii-san is registered as a committer of this patch,
> so I am not planning to go beyond a review here.

Thanks for the review! Yes, I will handle this patch.

Regards,

-- 
Fujii Masao