On 2018/10/05 14:56, Michael Paquier wrote:
> On Thu, Oct 04, 2018 at 05:18:07PM +0900, Michael Paquier wrote:
>> So it seems that I am clearly outvoted here ;)
>>
>> Okay, let's do as you folks propose.
>
> And attached is a newer version with this isleaf stuff and the previous
> feedback from Amit integrated, as long as I recall about it. The
> version is indented, and tutti-quanti. Does that look fine to everybody
> here?
Thanks for making those changes yourself and posting the new version.
Can you check the attached diff file for some updates to the documentation
part of the patch. Other parts look fine.
Thanks,
Amit
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index be315aaabb..826c59ecd9 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -20209,14 +20209,14 @@ postgres=# SELECT * FROM
pg_walfile_name_offset(pg_stop_backup());
<entry><literal><function>pg_partition_tree(<type>oid</type>)</function></literal></entry>
<entry><type>setof record</type></entry>
<entry>
- List information about table in a partition tree for a given
+ List information about tables in partition tree for a given
partitioned table, which consists of one row for each partition and
table itself. Information provided includes the OID of the partition,
- the OID of its immediate parent, if the partition is a leaf and its
- level in the hierarchy. The value of level begins at
- <literal>0</literal> for the input table in its role as the root of
- the partition tree, <literal>1</literal> for its partitions,
- <literal>2</literal> for their partitions, and so on.
+ the OID of its immediate parent, a boolean value telling if the
+ partition is a leaf, and an integer telling its level in the hierarchy.
+ The value of level begins at <literal>0</literal> for the input table
+ in its role as the root of the partition tree, <literal>1</literal> for
+ its partitions, <literal>2</literal> for their partitions, and so on.
</entry>
</row>
</tbody>
