On Thu, Jun 18, 2026 at 6:36 PM Chao Li <[email protected]> wrote:
> PFA v2: addressed David’s comments. > Looked a bit closer at printQuery this time; disliking that the if condition has an awareness of the implementation of printQueryOptDisplayValue since it lists !isnull and ftype != BOOLOID explicitly. How about not touching print.c at all with this patch, moving the printQueryOptDisplayValue into crosstabview.c and leaving printQuery alone since it is already correct? David J. P.S. When we do get to cleaning this up it seems annoying/odd that we determine whether to apply numeric locale based upon whether the display alignment for the column is right-aligned or not as opposed to the data type of the value.
