On Mon, Jun 15, 2026 at 2:32 PM jian he <[email protected]> wrote: > > Hi. > > More review based on https://github.com/assam258-5892/postgres/commits/RPR >
/* arity: a value expression and an optional offset */ Typo: arity I've attached a patch with some refactoring. Please note that the inline comments have not yet been updated to match this refactoring. The below is detailed commit message. ------------------------------------------------------------------------------------------------ Simplify ParseFuncOrColumn: It now routes to ParseRPRNavCall exclusively when ParseExprKind is EXPR_KIND_RPR_DEFINE *and* not column projection *and* list_length(funcname) == 1. Original behavior is preserved otherwise. Centralize error handling: Treat RPR navigation as FUNCDETAIL_NORMAL to reuse the common error handling in ParseFuncOrColumn, effectively stripping redundant error checks from ParseRPRNavCall. Other miscellaneous code cleanups and minor refactoring. ------------------------------------------------------------------------------------------------ -- jian https://www.enterprisedb.com/
v48-0001-Refactor-ParseFuncOrColumn-and-ParseRPRNavCall.nocfbot
Description: Binary data
