On Mon, Jun 15, 2026 at 11:36 AM Peter Smith <[email protected]> wrote: > > A trivial review comment for v50-0003. > > ====== > src/backend/replication/logical/conflict.c > > 1. > +void > +ProcessPendingConflictLogTuple(void) > +{ > + Relation conflictlogrel; > + ConflictLogDest dest; > + > + /* Nothing to do */ > + if (MyLogicalRepWorker->conflict_log_tuple == NULL) > + return; > + > + PG_TRY(); > + { > > Those 2 variables are only used within the PG_TRY block, so they can > be declared there. >
I request you to please collect all such code-level comments and share as one email. I know it is not always possible and sometimes it is good to share whatever one has reviewed. However, sometimes, I get the feeling that I may overlook some other key design related comment by someone which needs more discussion. I understand that I am no one to tell how you or someone should share her/his review but this is just a humble request and if you don't like it, feel free to ignore it. -- With Regards, Amit Kapila.
