Hi all, While looking at the TAP tests of pg_dump today, I have bumped into a dead reference to a command sequence named schema_only_with_statistics. This reference has been removed in 0ed92cf50cc4, and has been listed a couple of times after that, having no effect.
Let's clean up that as of the attached on HEAD, at least. v18 would be nice to include in the set, as this script is already complicated and that could create noise when backpatching. Comments or opinions? -- Michael
From 44964f62d1547c4c221202f7f164cc892367555d Mon Sep 17 00:00:00 2001 From: Michael Paquier <[email protected]> Date: Mon, 15 Jun 2026 17:04:23 +0900 Subject: [PATCH] Remove dead code in pg_dump TAP tests The schema_only_with_statistics test scenario was referenced in 002_pg_dump.pl, but was associated to no command sequence since 0ed92cf50cc4. --- src/bin/pg_dump/t/002_pg_dump.pl | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl index 3ee9fda50e4c..ca69720b759d 100644 --- a/src/bin/pg_dump/t/002_pg_dump.pl +++ b/src/bin/pg_dump/t/002_pg_dump.pl @@ -662,8 +662,7 @@ my %full_runs = ( no_table_access_method => 1, pg_dumpall_dbprivs => 1, pg_dumpall_exclude => 1, - schema_only => 1, - schema_only_with_statistics => 1,); + schema_only => 1,); # This is where the actual tests are defined. my %tests = ( @@ -880,7 +879,6 @@ my %tests = ( no_large_objects => 1, no_owner => 1, schema_only => 1, - schema_only_with_statistics => 1, }, }, @@ -1435,7 +1433,6 @@ my %tests = ( unlike => { binary_upgrade => 1, schema_only => 1, - schema_only_with_statistics => 1, no_large_objects => 1, }, }, @@ -1460,7 +1457,6 @@ my %tests = ( binary_upgrade => 1, no_large_objects => 1, schema_only => 1, - schema_only_with_statistics => 1, }, }, @@ -1483,7 +1479,6 @@ my %tests = ( binary_upgrade => 1, no_large_objects => 1, schema_only => 1, - schema_only_with_statistics => 1, }, }, @@ -1650,7 +1645,6 @@ my %tests = ( unlike => { no_large_objects => 1, schema_only => 1, - schema_only_with_statistics => 1, }, }, @@ -1833,7 +1827,6 @@ my %tests = ( exclude_test_table => 1, exclude_test_table_data => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1859,7 +1852,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1900,7 +1892,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1924,7 +1915,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1949,7 +1939,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1973,7 +1962,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -1997,7 +1985,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -3616,7 +3603,6 @@ my %tests = ( unlike => { binary_upgrade => 1, schema_only => 1, - schema_only_with_statistics => 1, exclude_measurement => 1, only_dump_test_schema => 1, test_schema_plus_large_objects => 1, @@ -4499,7 +4485,6 @@ my %tests = ( no_large_objects => 1, no_privs => 1, schema_only => 1, - schema_only_with_statistics => 1, }, }, @@ -4634,7 +4619,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -4651,7 +4635,6 @@ my %tests = ( binary_upgrade => 1, exclude_dump_test_schema => 1, schema_only => 1, - schema_only_with_statistics => 1, only_dump_measurement => 1, }, }, @@ -4850,7 +4833,6 @@ my %tests = ( no_schema => 1, section_post_data => 1, statistics_only => 1, - schema_only_with_statistics => 1, }, unlike => { exclude_dump_test_schema => 1, @@ -4878,7 +4860,6 @@ my %tests = ( no_schema => 1, section_post_data => 1, statistics_only => 1, - schema_only_with_statistics => 1, }, unlike => { exclude_dump_test_schema => 1, @@ -4907,7 +4888,6 @@ my %tests = ( section_data => 1, section_post_data => 1, statistics_only => 1, - schema_only_with_statistics => 1, }, unlike => { no_statistics => 1, -- 2.54.0
signature.asc
Description: PGP signature
