Hello. At Sat, 6 Jun 2026 21:32:22 +0100, Zakariyah Ali <[email protected]> wrote in > -git a/src/test/recovery/t/019_replslot_limit.pl > b/src/test/recovery/t/019_replslot_limit.pl > index a412faf51c6..3fdce739965 100644 > --- a/src/test/recovery/t/019_replslot_limit.pl > +++ b/src/test/recovery/t/019_replslot_limit.pl > @@ -186,18 +186,9 @@ $node_primary->advanc
(Some explanation of the motivation would be helpful.) These are test scripts, so unless there is some functional issue with the existing code, I'm not sure we should actively replace existing implementations with wait_for_log(). In other words, I would normally expect this kind of change to happen only when the surrounding code is being modified for some functional reason. As for this patch specifically, there are still other places using open-coded log searches (for example, 033_replay_tsp_drops.pl). If we decide to make this kind of change, I think it would make more sense to update similar cases together. Regards. -- Kyotaro Horiguchi NTT Open Source Software Center
