On 1 October 2018 at 19:39, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > For this and the other cases (AcquireRewriteLocks, AcquireExecutorLocks, > etc.), I wonder whether we couldn't just *not* recalculate the lock mode > based on inspecting the query tree to cross-check with rellockmode? Why > not just use rellockmode for locking? Maybe, okay to keep doing that in > debug builds though. Also, are the discrepancies like this to be > considered bugs of the existing logic?
I got the impression Tom was just leaving that in for a while to let the buildfarm verify the new code is getting the same lock level as the old code. Of course, I might be wrong. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
