Hi, On 09/26/2018 05:15 PM, Michael Banck wrote: > ... > > New version 5 attached. >
I've looked at v5, and the retry/recheck logic seems OK to me - I'd still vote to keep it consistent with what pg_basebackup does (i.e. doing the LSN check first, before looking at the checksum), but I don't think it's a bug. I'm not sure about the other issues brought up (ENOENT, short reads). I haven't given it much thought. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services