Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > I still don't see that as a reason for tools to be suseptible to serious > > issues if a funky user gets created and I'd be surprised if there > > weren't other ways to get funky characters into the log file, but that's > > all ultimately an independent issue from this. I'll add the comments as > > discussed and discourage using the clean ascii function, but otherwise > > keep things as-is in that regard. > > Updated patch with lots of comments added around pg_clean_ascii() about > why it exists, why we do the cleaning, and warnings to discourage people > from using it without good cause. I've also done some additional > testing with it and it seems to be working well. I'll poke at it a bit > more tomorrow but if there aren't any other concerns, I'll commit it > towards the end of the day.
Pushed, thanks all for the help and discussion, and thanks to Don for his patch! Thanks! Stephen
signature.asc
Description: PGP signature
