On Wed, Apr 22, 2026 at 12:23 PM Tom Lane <[email protected]> wrote: > I agree that we have no real ability to guarantee that. > Still, as far as the presented patch goes, it seems like a clear > win so I'd vote for fix-and-backpatch.
Sounds good to me. > Should we write the arguments as BIO_TYPE_NONE | BIO_TYPE_SOURCE_SINK > rather than just BIO_TYPE_SOURCE_SINK? Good question... Popularity-wise, the shorter spelling shows up across quite a few projects on GitHub, but the only spelling of `BIO_meth_new(BIO_TYPE_NONE | ...)` that I can find is a single place inside OpenSSL's own test suite -- which also uses the shorter alternative, in two places. So my vote is BIO_TYPE_SOURCE_SINK; we'll be in good company. Thanks, --Jacob
