On Thu, 16 Apr 2026 at 07:17, Peter Eisentraut <[email protected]> wrote: > Depending on what you end up doing, maybe a sprinkling of pg_nodiscard > could be appropriate.
Yeah maybe. It wouldn't do any harm, at least. I didn't do that in the patch I just sent as it felt like something we should do or not do for all the bitmapset functions it's relevant for. REALLOCATE_BITMAPSETS is meant to give us a stronger guarantee of people forgetting to do this, as it would cause a breakage if there were multiple pointers to the same set and only one of them got updated. David
