On 2018-09-26 11:09:59 -0400, Tom Lane wrote: > Michael Paquier <mich...@paquier.xyz> writes: > > On Tue, Sep 25, 2018 at 12:05:42PM -0400, Tom Lane wrote: > >> Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > >>> Actually I think it *is* useful to do it like this, because then the > >>> user knows to fix the netmsg.dll problem so that they can continue to > >>> investigate the winsock problem. If we don't report the secondary error > >>> message, how are users going to figure out how to fix the problem? > > >> OK, I'm fine with doing it like that if people want it. > > > +1. > > OK, pushed 0001 with that adjustment. > > While looking over the thread, I remembered I wanted to convert > strerror_r into a wrapper as well. Think I'll go do that next, > because really it'd be better for snprintf.c to be calling strerror_r > not strerror.
The strerror push, I assume it's that at least, broke something on icc: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fulmar&dt=2018-09-26%2018%3A00%3A16 ================== pgsql.build/src/test/regress/regression.diffs =================== *** /var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/expected/create_function_1.out Wed Sep 26 20:10:35 2018 --- /var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/results/create_function_1.out Wed Sep 26 20:10:43 2018 *************** *** 86,92 **** ERROR: only one AS item needed for language "sql" CREATE FUNCTION test1 (int) RETURNS int LANGUAGE C AS 'nosuchfile'; ! ERROR: could not access file "nosuchfile": No such file or directory CREATE FUNCTION test1 (int) RETURNS int LANGUAGE C AS '/var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/regress.so', 'nosuchsymbol'; ERROR: could not find function "nosuchsymbol" in file "/var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/regress.so" --- 86,92 ---- ERROR: only one AS item needed for language "sql" CREATE FUNCTION test1 (int) RETURNS int LANGUAGE C AS 'nosuchfile'; ! ERROR: could not access file "nosuchfile": ENOENT CREATE FUNCTION test1 (int) RETURNS int LANGUAGE C AS '/var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/regress.so', 'nosuchsymbol'; ERROR: could not find function "nosuchsymbol" in file "/var/buildfarm/fulmar/build/HEAD/pgsql.build/src/test/regress/regress.so" ====================================================================== Greetings, Andres Freund
