On Fri, Mar 6, 2026 at 2:44 PM Zsolt Parragi <[email protected]> wrote: > + if ((start_flow = dlsym(state->flow_module, "pg_start_oauthbearer")) == > NULL) > > And this path has the same issue, the library is there, so suggesting > to install libpq-oauth isn't helpful.
I'll cherry-pick some of the -1 handling backwards in the patchset to handle this. > + appendPQExpBuffer(&conn->errorMessage, > + "use_builtin_flow: failed to lock mutex (%d)\n", > + lockerr); > > This is after an assert, so maybe it is okay as is, but this bypasses > gettext. Correct. For PG18, I got the feedback that can't-happen errors in OAuth should really remain untranslated, unless it's clear that the user can act on them. Otherwise we're consuming translators' time for no practical benefit. > > (try installing the libpq-oauth package) > > This isn't changed in these patches, but Is it okay to assume a > package name here? No, not really, but see [1]. Any "vanilla" version of that error message will contain the string "libpq-oauth" regardless; that's the module's name. So package maintainers need to either patch the line if it's not useful, or else let us know how they'd prefer to override this -- Makefile? Configure? (Meson?) -- to improve the situation. Christoph gave the most feedback here, so Debian has the most-greased wheel at the moment. :D Thanks, --Jacob [1] https://postgr.es/m/aAOREVWMFTuWvJ1l%40msg.df7cb.de
