Hi, On Fri, Mar 6, 2026 at 12:00 PM Michael Paquier <[email protected]> wrote: > > On Thu, Mar 05, 2026 at 09:01:35PM +0800, Xuneng Zhou wrote: > > Here is the updated patch set. Please take a look. > > Thanks. It was mostly fine, still: > - The extra mention of ROLE_PG_READ_ALL_STATS was not necessary. We > already have one at the top of the section. > - After sleeping on it, I have decided to keep recoveryLastXTime, > partially because we have a system function to retrieve it already. > - There was a refactoring piece possible when we switch a > RecoveryPauseState to a non-translatable string, which I have applied > separately
It looks cleaner. > - Added one test with pg_stat_recovery checked on a standby. > -- > Michael Thanks for improving and pushing! -- Best, Xuneng
