On Wed, Mar 04, 2026 at 05:34:49PM -0500, Tom Lane wrote: > By my count, two-thirds of the buildfarm is broken. (100 failing > animals, 56 working ones have reported since this commit.) > > We would not normally tolerate leaving things that way for any > great length of time, and I don't think this commit should get > a pass. I think it needs to be reverted until a very much > larger fraction of buildfarm owners have prepared for it.
Hmm. If you guys feel strongly about it, I'd be OK to revert. Now there is a way to split the pie into two halves: we can still introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC if lz4 is included in the build but, leave the switch of --with-lz4 to --without-lz4 out of the equation. This choice would leave the buildfarm in piece, and it still achieves the goal of enabling LZ4 in TOAST by default, as long as --without-lz4 is used. As long as the latter is achieved, the point of the change would be made. Opinions? -- Michael
signature.asc
Description: PGP signature
