Thanks for the review, Japin. I’ve addressed all of your comments. I also added a check to throw an error if an option appears more than once.
Attached is the *v10 patch*, now ready for further review. On Wed, Mar 4, 2026 at 3:15 PM Álvaro Herrera <[email protected]> wrote: > On 2026-Mar-04, Japin Li wrote: > > > After playing with this patch, I’m seeing the following output: > > > > # select pg_get_database_ddl('postgres'::regdatabase, 'defaults', true, > 'pretty', true, 'pretty', false); > > I think this should throw an error that 'pretty' was contradictorily > specified twice. (Maybe also an error if an option appears twice, > period.) > > -- > Álvaro Herrera 48°01'N 7°57'E — > https://www.EnterpriseDB.com/ >
v10-0001-Add-pg_get_database_ddl-function-to-reconstruct-ddl.patch
Description: Binary data
