I noticed this cast in the committed code:

+ num_total_db = get_dbname_oid_list_from_mfile((char *) inputFileSpec, &dbname_oid_list);

The cast drops the const qualifier from inputFileSpec. get_dbname_oid_list_from_mfile() writes into the space pointed to by its argument, so it's really not "const". (And inputFileSpec points into argv, so this ends up writing directly into argv.)

Please see if you can clean this up. It might be best if get_dbname_oid_list_from_mfile() made a copy of its argument that it can write into, and then the argument can be "const".



Reply via email to