At Thu, 6 Sep 2018 16:37:28 -0700, Michael Paquier <mich...@paquier.xyz> wrote in <20180906233728.gr2...@paquier.xyz> > On Tue, Aug 28, 2018 at 07:34:36PM +0900, Kyotaro HORIGUCHI wrote: > > Thanks for prompting. The difference is in a comment and I'm fine > > with the change. > > /* > * Properly accept or ignore signals the postmaster might send us. > */ > - pqsignal(SIGHUP, StartupProcSigHupHandler); /* reload config file */ > + pqsignal(SIGHUP, SIG_IGN); /* ignore reload config */ > > I am finally coming back to this patch set, and that's one of the first > things I am going to help moving on for this CF. And this bit from the > last patch series is not acceptable as there are some parameters which > are used by the startup process which can be reloaded. One of them is > wal_retrieve_retry_interval for tuning when fetching WAL at recovery.
The third patch actually is not mandatory in the patch set. The only motive of that is it doesn't nothing. The handler for SIGHUP just sets got_SIGHUP then wakes up the process, and the variable is not looked up by no one. If you mind the change, it can be removed with no side effect. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
